Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11903#discussion_r57216493
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala 
---
    @@ -34,20 +34,23 @@ private[ml] object GradientBoostedTrees extends Logging 
{
       /**
        * Method to train a gradient boosting model
        * @param input Training dataset: RDD of 
[[org.apache.spark.mllib.regression.LabeledPoint]].
    +   * @param seed Random seed.
        * @return tuple of ensemble models and weights:
        *         (array of decision tree models, array of model weights)
        */
       def run(input: RDD[LabeledPoint],
    --- End diff --
    
    Scala style (not from your PR): This should be written:
    ```
    def run(
        input: RDD[LabeledPoint],
        boostingStrategy: ..,
        seed: Long): (Array[DecisionTreeRegressionModel], Array[Double]) = {
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to