Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9971#issuecomment-200596845
Initial comment: I like the idea of testing Validators jointly, but I don't
think creating a MyValidator class is the best way since it involves a lot of
new code and since that new code is mimicking what is already in
CrossValidator. I'd prefer to keep the original CrossValidatorSuite tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]