GitHub user tejasapatil opened a pull request:

    https://github.com/apache/spark/pull/11927

    [SPARK-14110] [CORE] PipedRDD to print the command ran on non zero exit

    ## What changes were proposed in this pull request?
    
    In case of failure in subprocess launched in PipedRDD, the failure 
exception reads “Subprocess exited with status XXX”. Debugging this is not 
easy for users especially if there are multiple pipe() operations in the Spark 
application. 
    
    Changes done:
    - Changed the exception message when non-zero exit code is seen
    - If the reader and writer threads see exception, simply logging the 
command ran. The current model is to propagate the exception "as is" so that 
upstream Spark logic will take the right action based on what the exception was 
(eg. for fetch failure, it needs to retry; but for some fatal exception, it 
will decide to fail the stage / job). So wrapping the exception with a generic 
exception will not work. Altering the exception message will keep that 
guarantee but that is ugly (plus not all exceptions might have a constructor 
for a string message)
    
    ## How was this patch tested?
    
    - Added a new test case
    - Ran all existing tests for PipedRDD

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tejasapatil/spark SPARK-14110-piperdd-failure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11927.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11927
    
----
commit c194d731686e16f9baf062f3a9321572b206fdaa
Author: Tejas Patil <[email protected]>
Date:   2016-03-24T03:49:11Z

    PipedRDD to print the command ran on non zero exit
    
    - Changed the exception message when non-zero exit code is seem
    - If the reader and writer threads see exception, we simply log the command 
ran. This is done because we want to propagate the exception as is so that 
upstream Spark logic will take the right action based on what the exception was 
(eg. for fetch failure, it needs to retry; but for some fatal exception, it 
will decide to fail the stage / job)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to