GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/11931

    [SPARK-13456][SQL][follow-up] lazily generate the outer pointer for case 
class defined in REPL

    ## What changes were proposed in this pull request?
    
    In https://github.com/apache/spark/pull/11410, we missed a corner case: 
define the inner class and use it in `Dataset` at the same time by using paste 
mode. For this case, the inner class and the `Dataset` are inside same line 
object, when we build the `Dataset`, we try to get outer pointer from line 
object, and it will fail because the line object is not initialized yet.
    
    This PR make the process of getting outer pointer from line object lazy, so 
that we can successfully build the `Dataset` and finish initializing the line 
object.
    
    ## How was this patch tested?
    
    todo (how to simulate the past mode in our repl suite?)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark repl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11931
    
----
commit 05cec9ad4d465f9eac5d7f4a893b76115e3fbfe8
Author: Wenchen Fan <[email protected]>
Date:   2016-03-24T07:20:49Z

    lazily generate the outer pointer for case class defined in REPL

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to