Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1612#discussion_r15506043
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
    @@ -81,8 +105,10 @@ class JdbcRDD[T: ClassTag](
           logInfo("statement fetch size set to: " + stmt.getFetchSize + " to 
force MySQL streaming ")
         }
     
    -    stmt.setLong(1, part.lower)
    -    stmt.setLong(2, part.upper)
    +    val parameterCount = stmt.getParameterMetaData.getParameterCount
    +    if (parameterCount > 0) stmt.setLong(1, part.lower)
    +    if (parameterCount > 1) stmt.setLong(2, part.upper)
    +
    --- End diff --
    
    This is not what your mean here. It is something like `SELECT * FROM tbl 
limit ?, ?`. But there is probably a bug in original implementation, as I 
remember the second parameter of `LIMIT` clause in MySQL is the `row_count`, 
not the `upper`. see: http://dev.mysql.com/doc/refman/5.0/en/select.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to