Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1056#discussion_r15506106
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -23,6 +23,14 @@ import org.apache.spark.storage.{BlockId, BlockStatus}
/**
* :: DeveloperApi ::
* Metrics tracked during the execution of a task.
+ *
+ * This class is used to house metrics both for in-progress and completed
tasks. In executors,
+ * both the task thread and the heartbeat thread write to the TaskMetrics.
The heartbeat thread
+ * reads it to send in-progress metrics, and the task thread reads it to
send metrics along with
+ * the completed task.
+ *
+ * So, when adding new fields, take into consideration that the whole
object can be serialized for
+ * shipping off at any time to consumers of the SparkListener interface..
--- End diff --
extra period.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
