Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11939#discussion_r57367124
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -444,7 +444,14 @@ def _setDefault(self, **kwargs):
Sets default params.
"""
for param, value in kwargs.items():
- self._defaultParamMap[getattr(self, param)] = value
+ p = getattr(self, param)
--- End diff --
In a previous PR a parameter was given an incorrect type converter, and
this was not caught by the tests. Enforcing `_setDefault` to use the type
converter for the param will ensure that all params with default values cannot
be given incompatible type converters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
