Github user burakkose commented on the pull request:
https://github.com/apache/spark/pull/11871#issuecomment-201069222
@mengxr, Alright then, these are my plans.
I am going to merge `StopWords` with `StopWordsRemover`(delete
readStopWords), and we will read stopwords list from `loadStopWords` in object
`StopWordsRemover`. So If users want to load stopwords directly, they will do
that.
`val stopWords = StopWordsRemover.loadStopWords("english").toSet`
But I have a question about `language` param. If we don't keep the param,
how should they do this?
```scala
val remover = new StopWordsRemover()
.setInputCol("raw")
.setOutputCol("filtered")
.setLanguage("danish")
```
Should we force to do that?
```scala
val stopWords = StopWordsRemover.loadStopWords("danish").toSet ++
Set("python", "scala")
val remover = new StopWordsRemover()
.setInputCol("raw")
.setOutputCol("filtered")
.setStopWords(stopWords.toArray)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
