Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1632#discussion_r15508224
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/BlockFetcherIterator.scala ---
    @@ -117,31 +121,45 @@ object BlockFetcherIterator {
           })
           bytesInFlight += req.size
           val sizeMap = req.blocks.toMap  // so we can look up the size of 
each blockID
    -      val future = connectionManager.sendMessageReliably(cmId, 
blockMessageArray.toBufferMessage)
    -      future.onSuccess {
    -        case Some(message) => {
    -          val bufferMessage = message.asInstanceOf[BufferMessage]
    -          val blockMessageArray = 
BlockMessageArray.fromBufferMessage(bufferMessage)
    -          for (blockMessage <- blockMessageArray) {
    -            if (blockMessage.getType != BlockMessage.TYPE_GOT_BLOCK) {
    -              throw new SparkException(
    -                "Unexpected message " + blockMessage.getType + " received 
from " + cmId)
    +
    +      val sendRequestThread = new 
Thread(s"sendRequestThread(${req.address.host}:${req.address.port})") {
    --- End diff --
    
    New thread affect performance?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to