GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/11966
[MINOR][MLLIB] Change parameter `categories` type from Seq to List.
## What changes were proposed in this pull request?
This PR fixes the following line and the related code. Historically, this
code was added in SPARK-5597. After SPARK-5597 was committed, SPARK-3365 is
fixed now. So, we had better change that type and remove the comments.
```scala
- categories: Seq[Double]) { // TODO: Change to List once SPARK-3365
is fixed
+ categories: List[Double]) {
```
## How was this patch tested?
Pass the Jenkins tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark change_categories_type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11966.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11966
----
commit cbc26c5f12a44ae359b5567850769338d7e4b82c
Author: Dongjoon Hyun <[email protected]>
Date: 2016-03-25T20:41:45Z
[MINOR][MLLIB] Change parameter `categories` type from Seq to List.
After SPARK-5597 was committed, SPARK-3365 is fixed. Now we can change that
type safely and remove the comments.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
