Github user traviscrawford commented on a diff in the pull request:
https://github.com/apache/spark/pull/11967#discussion_r57490820
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -402,13 +404,7 @@ final class DataFrameNaFunctions private[sql](df:
DataFrame) {
* Returns a [[Column]] expression that replaces null value in `col`
with `replacement`.
*/
private def fillCol[T](col: StructField, replacement: T): Column = {
- col.dataType match {
- case DoubleType | FloatType =>
- coalesce(nanvl(df.col("`" + col.name + "`"), lit(null)),
--- End diff --
The data type pattern match has been removed because I believe its
unnecessary. I'm happy to put this back, along with a comment describing what
special-case it covers, if someone can clue me into why its needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
