Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1346#discussion_r15510908
--- Diff: python/pyspark/sql.py ---
@@ -20,8 +20,457 @@
from py4j.protocol import Py4JError
-__all__ = ["SQLContext", "HiveContext", "LocalHiveContext",
"TestHiveContext", "SchemaRDD", "Row"]
+__all__ = [
+ "StringType", "BinaryType", "BooleanType", "TimestampType",
"DecimalType",
+ "DoubleType", "FloatType", "ByteType", "IntegerType", "LongType",
+ "ShortType", "ArrayType", "MapType", "StructField", "StructType",
+ "SQLContext", "HiveContext", "LocalHiveContext", "TestHiveContext",
"SchemaRDD", "Row"]
+class PrimitiveTypeSingleton(type):
+ _instances = {}
+ def __call__(cls):
+ if cls not in cls._instances:
+ cls._instances[cls] = super(PrimitiveTypeSingleton,
cls).__call__()
+ return cls._instances[cls]
+
+class StringType(object):
--- End diff --
I think PEP8 requires two blank lines to separate top level classes.
Better run the pep8 checker on files changed by this PR since most other
files are now pep8 clean, and we will add a pep8 checker to jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
