Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/11720#discussion_r57586861
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -286,6 +286,7 @@ class DAGScheduler(
case None =>
// We are going to register ancestor shuffle dependencies
getAncestorShuffleDependencies(shuffleDep.rdd).foreach { dep =>
+ assert(!shuffleToMapStage.get(dep.shuffleId).isDefined)
--- End diff --
Yes, but it is not immediately obvious that that is inappropriate. I need
to spend some time re-familiarizing myself with newOrUsedShuffleStage. In any
event, just failing an assertion in the middle of the DAGScheduler is not
likely something we want to do. At a bare minimum, we'd want to be logging a
more useful error message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
