Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11999#discussion_r57601423
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
    @@ -549,15 +549,18 @@ class HDFSFileCatalog(
     
       refresh()
     
    +  private def isInvalidFile(f: FileStatus): Boolean =
    +    f.getPath.getName.startsWith("_") || f.getLen == 0
    --- End diff --
    
    Actually there is an existing [CSV test case][1] that cover empty CSV input 
files. I have to [remove the empty file assertion][2] in `FileSourceStrategy` 
for this test case when implementing `buildReader()` for CSV.
    
    [1]: 
https://github.com/apache/spark/blob/e5a1b301fbe191f1a9627a1083d960c98f543d13/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala#L248-L256
    [2]: https://github.com/apache/spark/pull/12002#discussion_r57594679


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to