Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10355#issuecomment-202603261
This looks to be in very good shape. My main comment is about unit test
time: the tests take a significant amount of time. Wherever it is easy to do,
could you set the algorithm parameters to make for faster tests? E.g., use 1
iteration for LogisticRegression, use maxDepth 0 for trees, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
