Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12025#discussion_r57667080
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -297,7 +297,7 @@ case class WholeStageCodegen(child: SparkPlan) extends
UnaryNode with CodegenSup
"pipelineTime" -> SQLMetrics.createTimingMetric(sparkContext,
WholeStageCodegen.PIPELINE_DURATION_METRIC))
- override def doExecute(): RDD[InternalRow] = {
+ private[sql] def doCodeGen(): (CodegenContext, String) = {
--- End diff --
you can remove the private[sql] - everything in execution is considered
private.
Can you add comment explaining what the return tuple means?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
