Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r57723611
--- Diff: core/src/main/scala/org/apache/spark/partial/BoundedDouble.scala
---
@@ -21,5 +21,20 @@ package org.apache.spark.partial
* A Double value with error bars and associated confidence.
*/
class BoundedDouble(val mean: Double, val confidence: Double, val low:
Double, val high: Double) {
- override def toString(): String = "[%.3f, %.3f]".format(low, high)
+ override def toString(): String = "BoundedDouble(%.3f, %.3f, %.3f,
%.3f)".format(mean, confidence, low, high)
--- End diff --
I was going to say that this can become a case class to get this all for
free, but it's part of the API. In theory that doesn't change anything, so you
can try a case class and see if MiMa accepts it. Otherwise you can do this, but
you'll need to fix up a few little style things. I'd not change the toString,
hashCode might be too long a line, and indent on equals is too deep
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
