Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12036#discussion_r57769684
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionState.scala ---
    @@ -71,7 +71,7 @@ private[hive] class HiveSessionState(ctx: HiveContext) 
extends SessionState(ctx)
       /**
        * Parser for HiveQl query texts.
        */
    -  override lazy val sqlParser: ParserInterface = HiveSqlParser
    +  override lazy val sqlParser: ParserInterface = HiveSqlParser(this)
    --- End diff --
    
    don't pass in the `SessionState` here if you're just gonna use the function 
registry. In general it's better to pass in narrower things so we don't have a 
tight coupling across classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to