Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12038#discussion_r57784984
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportFrameDecoder.java
---
@@ -139,14 +139,18 @@ private ByteBuf decodeNext() throws Exception {
return nextBufferForFrame(remaining);
}
- // Otherwise, create a composite buffer.
- CompositeByteBuf frame = buffers.getFirst().alloc().compositeBuffer();
--- End diff --
Why is it not a good choice? With your change, you're replacing "maybe copy
multiple times" with "always copy once". If there's a way to avoid the copy
altogether, why not do it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
