Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12047#discussion_r57809576
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -224,9 +224,13 @@ public ColumnarBatch resultBatch() {
/**
* Can be called before any rows are returned to enable returning
columnar batches directly.
+ *
+ * @param maxColumns The maximum number of fields supported by whole
stage codegen.
*/
- public void enableReturningBatches() {
- returnColumnarBatch = true;
+ public boolean tryEnableReturningBatches(int maxColumns) {
--- End diff --
Yes, we should do this in planner, by checking the schema, which requires
some cleanup in parquet reader, currently which still use runtime exception to
do the switch. cc @nongli @sameeragarwal
Should we wait for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
