Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11976#discussion_r57817773
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
    @@ -78,6 +79,26 @@ final class DataFrameWriter private[sql](df: DataFrame) {
       }
     
       /**
    +   * Set the trigger interval for the stream query.
    +   *
    +   * @since 2.0.0
    +   */
    +  def trigger(interval: Duration): DataFrameWriter = {
    +    this.extraOptions += ("triggerInterval" -> interval.toMillis.toString)
    --- End diff --
    
    > how would we extend this to support other types of triggers? The design 
doc suggests using using classes I think.
    
    We can add a new method `triggerMode` to support other types of triggers 
like how we supports different `SaveMode`s. This would be better than adding 
new classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to