Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11934#discussion_r57827885
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/DefaultSource.scala
---
@@ -125,6 +126,33 @@ class DefaultSource extends FileFormat with
DataSourceRegister {
}
}
}
+
+ override def buildReader(
+ sqlContext: SQLContext,
+ partitionSchema: StructType,
+ dataSchema: StructType,
+ filters: Seq[Filter],
+ options: Map[String, String]): PartitionedFile =>
Iterator[InternalRow] = {
+ verifySchema(dataSchema)
+
+ val conf = new
Configuration(sqlContext.sparkContext.hadoopConfiguration)
+ val broadcastedConf =
+ sqlContext.sparkContext.broadcast(new
SerializableConfiguration(conf))
+
+ val unsafeRow = new UnsafeRow(1)
+ val bufferHolder = new BufferHolder(unsafeRow)
+ val unsafeRowWriter = new UnsafeRowWriter(bufferHolder, 1)
--- End diff --
These are not serializable and need to be moved into the the closure.
Also, is this the same as the following?
```scala
val encoder = ExpressionEncoder[String]()
new HadoopFileLinesReader(file,
broadcastedConf.value.value).map(encoder.toRow)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
