Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/12055#discussion_r57844666
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/VectorizedHashMap.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.vectorized;
+
+import java.util.Arrays;
+
+import org.apache.spark.memory.MemoryMode;
+import org.apache.spark.sql.types.StructType;
+
+import static org.apache.spark.sql.types.DataTypes.LongType;
+
+/**
+ * This is an illustrative implementation of a single-key/single value
vectorized hash map that can
+ * be potentially 'codegened' in TungstenAggregate to speed up aggregate
w/ key
+ */
+public class VectorizedHashMap {
+ public ColumnarBatch batch;
+ public int[] buckets;
+ private int numBuckets;
+ private int numRows = 0;
+ private int maxSteps = 3;
+
+ public VectorizedHashMap(int capacity, double loadFactor, int maxSteps) {
--- End diff --
I think this should take the schema as the parameter.
capacity needs to be a power of 2 for the mod to work. I'm not sure these
should be exposed for the typical caller. At the very least, expose a ctor with
reasonable defaults.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
