Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12033#discussion_r57860863
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONRelation.scala
---
@@ -148,10 +147,7 @@ class DefaultSource extends FileFormat with
DataSourceRegister {
columnNameOfCorruptRecord,
parsedOptions)
- val appendPartitionColumns =
GenerateUnsafeProjection.generate(fullSchema, fullSchema)
- rows.map { row =>
- appendPartitionColumns(joinedRow(row, file.partitionValues))
- }
+ FileFormat.appendPartitionValues(rows, fullSchema,
file.partitionValues)
--- End diff --
Makes sense. We may also add a `appendPartitionValues` method in
`buildReader`, so that partition value appending can be abstracted away using a
default implementation. Only special data sources like Parquet need to override
and take care of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
