Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1551#discussion_r15554294
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala 
---
    @@ -312,42 +314,51 @@ private[spark] object PythonRDD extends Logging {
         JavaRDD.fromRDD(sc.sc.parallelize(objs, parallelism))
       }
     
    +  @tailrec
       def writeIteratorToStream[T](iter: Iterator[T], dataOut: 
DataOutputStream) {
         // The right way to implement this would be to use TypeTags to get the 
full
         // type of T.  Since I don't want to introduce breaking changes 
throughout the
         // entire Spark API, I have to use this hacky approach:
    +    def writeBytes(bytes: Array[Byte]) {
    --- End diff --
    
    Is there a legitimate case where a Iterator[Array[Byte]] will contain a 
null?  I was hoping we'd only have to worry about nulls in Iterator[String].


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to