Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12073#discussion_r57968820
--- Diff: external/java8-tests/pom.xml ---
@@ -87,74 +82,26 @@
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <executions>
- <execution>
- <id>test</id>
- <goals>
- <goal>test</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <systemPropertyVariables>
- <!-- For some reason surefire isn't setting this log4j file on
the
- test classpath automatically. So we add it manually. -->
- <log4j.configuration>
- file:src/test/resources/log4j.properties
- </log4j.configuration>
- </systemPropertyVariables>
- <skipTests>false</skipTests>
- <includes>
- <include>**/Suite*.java</include>
- <include>**/*Suite.java</include>
- </includes>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <executions>
- <execution>
- <id>test-compile-first</id>
- <phase>process-test-resources</phase>
- <goals>
- <goal>testCompile</goal>
- </goals>
- </execution>
- </executions>
<configuration>
- <fork>true</fork>
- <verbose>true</verbose>
<forceJavacCompilerUse>true</forceJavacCompilerUse>
<source>1.8</source>
- <compilerVersion>1.8</compilerVersion>
<target>1.8</target>
- <encoding>UTF-8</encoding>
- <maxmem>1024m</maxmem>
+ <compilerVersion>1.8</compilerVersion>
</configuration>
</plugin>
<plugin>
- <!-- disabled -->
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
- <executions>
--- End diff --
AFAIK the idea behind this logic was to ensure that Java files would not be
compiled by the Scala maven plugin, but disabling this has the side-effect of
preventing this module's Scala test source file from being compiled and run in
the Maven build.
Instead, I think it's okay to just modify the Scala Maven Plugin's
`javacArgs` configuration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
