Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12049#discussion_r57974037
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala ---
@@ -81,4 +85,62 @@ class StreamSuite extends StreamTest with
SharedSQLContext {
AddData(inputData, 1, 2, 3, 4),
CheckAnswer(2, 4))
}
+
+ test("DataFrame reuse") {
+ def assertDF(df: DataFrame) {
+ withTempDir { outputDir =>
+ withTempDir { checkpointDir =>
+ val query = df.write.format("parquet")
+ .option("checkpointLocation", checkpointDir.getAbsolutePath)
+ .startStream(outputDir.getAbsolutePath)
+ try {
+ eventually(timeout(streamingTimeout)) {
--- End diff --
> I'd like to ban use of eventually. Most of our tests that rely on this
construct end up being flakey.
As there are two threads here, even if not using `eventually`, we still to
need to use `await` or other similar stuff in order to collect results from
another thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
