Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58062792
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -510,16 +513,22 @@ class SparkSqlAstBuilder extends AstBuilder {
* For example:
* {{{
* ALTER TABLE table ADD [IF NOT EXISTS] PARTITION spec [LOCATION
'loc1']
+ * ALTER VIEW view ADD [IF NOT EXISTS] PARTITION spec
* }}}
*/
override def visitAddTablePartition(
ctx: AddTablePartitionContext): LogicalPlan = withOrigin(ctx) {
// Create partition spec to location mapping.
- val specsAndLocs = ctx.partitionSpecLocation.asScala.map {
- splCtx =>
- val spec = visitNonOptionalPartitionSpec(splCtx.partitionSpec)
- val location = Option(splCtx.locationSpec).map(visitLocationSpec)
- spec -> location
+ val specsAndLocs = if (ctx.partitionSpecLocation.isEmpty) {
--- End diff --
Minor: I slightly prefer checking if `partitionSpec` is non empty. This is
effectively the same, since they are mutally exclusive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
