Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11969#discussion_r58118427
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -239,11 +239,12 @@ private[spark] class Executor(
               val freedMemory = taskMemoryManager.cleanUpAllAllocatedMemory()
     
               if (freedMemory > 0) {
    -            val errMsg = s"Managed memory leak detected; size = 
$freedMemory bytes, TID = $taskId"
    +            val errMsg = s"Potential managed memory leak detected; " +
    +              s"size = $freedMemory bytes, TID = $taskId.  See 
SPARK-14168."
    --- End diff --
    
    well, I was thinking that even its a WARN, a memory leak is still 
concerning to a user, so I wanted to explain to the user the cases where it was 
a known false-positive.  But I couldn't come up with a short yet adequate thing 
to throw into the msg, so I figured the full explanation was contained in the 
jira.
    
    Sorry I should have mentioned that in the first place, and just changing to 
warn is fine in any case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to