Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11517#discussion_r58170614
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
 ---
    @@ -85,6 +85,66 @@ class BenchmarkWholeStageCodegen extends SparkFunSuite {
         */
       }
     
    +  ignore("range/sample/sum") {
    +    val N = 500 << 20
    +    runBenchmark("range/sample/sum", N) {
    +      sqlContext.range(N).sample(true, 0.8).groupBy().sum().collect()
    +    }
    +    /*
    +    Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
    +    range/sample/sum:                   Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
    +    
-------------------------------------------------------------------------------------------
    +    range/sample/sum codegen=false         55656 / 56490          9.4      
   106.2       1.0X
    +    range/sample/sum codegen=true          35423 / 35758         14.8      
    67.6       1.6X
    +    */
    +
    +    runBenchmark("range/sample/sum", N) {
    +      sqlContext.range(N).sample(false, 0.8).groupBy().sum().collect()
    +    }
    +    /*
    +    Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
    +    range/sample/sum:                   Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
    +    
-------------------------------------------------------------------------------------------
    +    range/sample/sum codegen=false         16460 / 17161         31.9      
    31.4       1.0X
    +    range/sample/sum codegen=true            4081 / 5390        128.5      
     7.8       4.0X
    +    */
    +  }
    +
    +  ignore("sort merge join/sample") {
    --- End diff --
    
    We may do not want this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to