Github user rajeshbalamohan commented on the pull request:

    https://github.com/apache/spark/pull/11978#issuecomment-204307805
  
    @andrewor14  - Not sure if I understood your last comment.  Currently no 
direct invocation to  HadoopRDD (with initLocalJobConfFuncOpt) is made in 
Spark. Later point in time, if change is needed to invoke HadoopRDD (with 
initLocalJobConfFuncOpt)  via SparkContext, following method could be added 
which cleans up the function.  
    
    ```
    def hadoopRDD[K, V](
           broadcastedConf: Broadcast[SerializableConfiguration],
           initLocalJobConfFuncOpt: Option[JobConf => Unit],
           inputFormatClass: Class[_ <: InputFormat[K, V]],
           keyClass: Class[K],
           valueClass: Class[V],
           minPartitions: Int = defaultMinPartitions): RDD[(K, V)] = withScope {
        assertNotStopped()
        clean(initLocalJobConfFuncOpt)
        new HadoopRDD(this, broadcastedConf, initLocalJobConfFuncOpt,
          inputFormatClass, keyClass, valueClass, minPartitions)
      }
    ```
    
    But, I am not sure whether we need to clean sc.hadoopRDD in this patch. 
Please let me know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to