Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11939#discussion_r58248687
--- Diff: python/pyspark/ml/feature.py ---
@@ -1721,7 +1721,7 @@ def __init__(self, inputCol=None, outputCol=None,
stopWords=None,
self._java_obj =
self._new_java_obj("org.apache.spark.ml.feature.StopWordsRemover",
self.uid)
stopWordsObj = _jvm().org.apache.spark.ml.feature.StopWords
- defaultStopWords = stopWordsObj.English()
+ defaultStopWords = list(stopWordsObj.English())
--- End diff --
It is simple to make this change, so I think it's a good idea. This will
help in the future for similar cases or if the list of stopwords grows even
larger. I changed `getStopWords` to return a list always which is better for
users, I think. Thanks for the suggestion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
