Github user dhruve commented on a diff in the pull request:
https://github.com/apache/spark/pull/12115#discussion_r58267823
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -819,12 +819,22 @@ private[spark] class Client(
javaOpts += "-XX:CMSIncrementalDutyCycle=10"
}
- // Include driver-specific java options if we are launching a driver
- if (isClusterMode) {
--- End diff --
In the cluster mode, the memory settings provided for the driver are
applied. And in the client mode, the driver and am settings are applied
individually. So in both cases we have to check the driver settings.
We haven't moved the (isClusterMode) check, its introduced to ensure that
the supplied extraJavaOptions are added when running in the cluster mode only
and are not included in the client mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
