Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12133#discussion_r58314666
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala 
---
    @@ -374,6 +374,54 @@ case class ShowDatabasesCommand(databasePattern: 
Option[String]) extends Runnabl
     }
     
     /**
    + * A command for users to list the properties for a table If propertyKey 
is specified, the value
    + * for the propertyKey is returned. If propertyKey is not specified, all 
the keys and their
    + * corresponding values are returned.
    + * The syntax of using this command in SQL is:
    + * {{{
    + *   SHOW TBLPROPERTIES table_name[('propertyKey')];
    + * }}}
    + */
    +case class ShowTablePropertiesCommand(
    +    table: TableIdentifier,
    +    propertyKey: Option[String]) extends RunnableCommand {
    +
    +  override val output: Seq[Attribute] = {
    +    val withKeySchema: Seq[Attribute] = {
    --- End diff --
    
    MINOR/NIT: This is still more elaborate than it needs to be. Why not:
    
        val schema = AttributeReference("value", StringType, nullable = 
false)() :: Nil
        propertyKey match {
          case None => AttributeReference("key", StringType, nullable = 
false)() :: schema
          case _ => schema
        }



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to