Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/11980#discussion_r58319194
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -120,17 +120,19 @@ object RowEncoder {
case StructType(fields) =>
val convertedFields = fields.zipWithIndex.map { case (f, i) =>
- val method = if (f.dataType.isInstanceOf[StructType]) {
- "getStruct"
+ val x = extractorsFor(
+ GetExternalRowField(inputObject, i,
externalDataTypeForInput(f.dataType), f.nullable),
+ f.dataType
+ )
+ if (f.nullable) {
+ If(
--- End diff --
if we do the null check inside GetExternalRowField then the code for
serializerFor also needs to be pushed into it (to be inside the null check),
and i can not figure out how to do that...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
