Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12117#discussion_r58329961
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -175,13 +175,54 @@ case class DescribeDatabase(
       }
     }
     
    +/**
    + * The DDL command that creates a function.
    + * alias: the class name that implements the created function.
    + * resources: Jars, files, or archives which need to be added to the 
environment when the function
    + *            is referenced for the first time by a session.
    + * isTemp: indicates if it is a temporary function.
    + */
    +// TODO: Use Seq[FunctionResource] instead of Seq[(String, String)] for 
resources.
     case class CreateFunction(
    --- End diff --
    
    can we move the function related commands out, i.e.
    
    functions.scala
    
    this file is going to become thousands of lines long.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to