Github user ksakellis commented on a diff in the pull request:
https://github.com/apache/spark/pull/12142#discussion_r58330267
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -249,6 +250,8 @@ trait SparkListener {
* Called when other events like SQL-specific events are posted.
*/
def onOtherEvent(event: SparkListenerEvent) { }
+
+ // WHENEVER WE ADD A METHOD HERE, PLEASE ALSO UPDATE
SparkFirehoseListener.
--- End diff --
We can have both this abstract class and also an interface? That way the
SparkFirehoseListener can just implement the interface instead of extending the
abstract class. Not sure if that is a better situation or not - it does make it
more flexible though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
