Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1498#discussion_r15567087
  
    --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala ---
    @@ -89,7 +91,7 @@ class ContextCleanerSuite extends FunSuite with 
BeforeAndAfter with LocalSparkCo
       }
     
       test("automatically cleanup RDD") {
    -    var rdd = newRDD.persist()
    +    var rdd = newRDD().persist()
    --- End diff --
    
    Does assertCleanup below also check that this RDD's broadcast was cleaned? 
It seems like it doesn't, since you only pass in the RDD ID. Maybe we can also 
grab its broadcast ID somehow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to