Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11729#issuecomment-205480898
Some high-level comments:
* It would be great to mimic one of the existing R-based tests:
* Run on a small dataset in R (You can see how those other tests do
that.)
* Print the summary in R
* Copy the R code into a comment in the Scala unit test
* Copy the R summary into a String in the Scala unit test
* Compare the 2 printed summaries. If this can be done via a simple
string comparison, great. If not, I'd like to compare the values and the
formatting in some way; we could discuss possibilities.
* Please follow the Scala style guide
[https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide].
It's easiest to compare with other code in Spark itself.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
