Github user bomeng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12117#discussion_r58454116
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ---
    @@ -534,17 +579,11 @@ class SessionCatalog(
         val dbFunctions =
           externalCatalog.listFunctions(db, pattern).map { f => 
FunctionIdentifier(f, Some(db)) }
         val regex = pattern.replaceAll("\\*", ".*").r
    --- End diff --
    
    I may create another PR for put all the pattern stuff in one place. Right 
now, it was scattered all over with replaceAll(). Please keep your code as it 
is for now, I will do it later. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to