Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/12155#discussion_r58472994
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -225,17 +228,21 @@ class StreamExecution(
}
/**
- * Queries all of the sources to see if any new data is available. When
there is new data the
- * batchId counter is incremented and a new log entry is written with
the newest offsets.
- *
- * Note that committing the offsets for a new batch implicitly marks the
previous batch as
- * finished and thus this method should only be called when all
currently available data
- * has been written to the sink.
+ * Commit the batch. Note that committing the offsets for a new batch
implicitly marks the
+ * previous batch as finished and thus this method should only be called
when all currently
+ * available data has been written to the sink.
*/
- private def commitAndConstructNextBatch(): Boolean = {
+ private def commitBatch(): Unit = {
--- End diff --
And in that case, the current log line at the end of runBatch is sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
