Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12157#discussion_r58517250
--- Diff: core/src/main/scala/org/apache/spark/Partition.scala ---
@@ -26,6 +26,11 @@ trait Partition extends Serializable {
*/
def index: Int
+ override def equals(other: Any): Boolean = other match {
+ case that: Partition => super.equals(that) && that.index == index
--- End diff --
If all the subclasses override these methods (and some implement some
custom logic), then this isn't used, and maybe it's simpler to omit it. If this
stays, yes, you're right that it really has to check the class of itself vs the
argument too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
