Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r58519101
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -440,12 +440,9 @@ final class OnlineLDAOptimizer extends LDAOptimizer {
val stat = BDM.zeros[Double](k, vocabSize)
var gammaPart = List[BDV[Double]]()
nonEmptyDocs.foreach { case (_, termCounts: Vector) =>
- val ids: List[Int] = termCounts match {
- case v: DenseVector => (0 until v.size).toList
- case v: SparseVector => v.indices.toList
- }
+ val ids: List[Int] = LDAUtils.vectorAsList(termCounts)
--- End diff --
I see what you're optimizing here, but the cost is making all the other
callers compute this. Is it enough of a performance bottleneck to bother? Is it
at all sensible to simply return `ids` from the existing method call instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
