Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58547959
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -68,10 +91,14 @@ case class DropTable(
// Users should be able to drop such kinds of tables regardless if
there is an error.
case e: Throwable => log.warn(s"${e.getMessage}", e)
}
- hiveContext.invalidateTable(tableName)
- hiveContext.runSqlHive(s"DROP TABLE $ifExistsClause$tableName")
- hiveContext.sessionState.catalog.dropTable(
- TableIdentifier(tableName), ignoreIfNotExists = true)
+ hiveContext.invalidateTable(tableName.quotedString)
+ val ifExistsClause = if (ifExists) "IF EXISTS " else ""
+ if (isView) {
+ hiveContext.runSqlHive(s"DROP VIEW
$ifExistsClause${tableName.quotedString}")
+ } else {
+ hiveContext.runSqlHive(s"DROP TABLE
$ifExistsClause${tableName.quotedString}")
--- End diff --
I think we should remove these two `runSqlHive` calls. We just use
SessionCatalog to handle metadata.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
