GitHub user srowen opened a pull request:

    https://github.com/apache/spark/pull/1660

    SPARK-2749 [BUILD]. Spark SQL Java tests aren't compiling in Jenkins' Maven 
builds; missing junit:junit dep

    The Maven-based builds in the build matrix have been failing for a few days:
    
    https://amplab.cs.berkeley.edu/jenkins/view/Spark/
    
    On inspection, it looks like the Spark SQL Java tests don't compile:
    
    
https://amplab.cs.berkeley.edu/jenkins/view/Spark/job/Spark-Master-Maven-pre-YARN/hadoop.version=1.0.4,label=centos/244/consoleFull
    
    I confirmed it by repeating the command vs master:
    
    `mvn -Dhadoop.version=1.0.4 -Dlabel=centos -DskipTests clean package`
    
    The problem is that this module doesn't depend on JUnit. In fact, none of 
the modules do, but `com.novocode:junit-interface` (the SBT-JUnit bridge) pulls 
it in, in most places. However this module doesn't depend on 
`com.novocode:junit-interface`
    
    Adding the `junit:junit` dependency fixes the compile problem. In fact, the 
other modules with Java tests should probably depend on it explicitly instead 
of happening to get it via `com.novocode:junit-interface`, since that is a bit 
SBT/Scala-specific (and I am not even sure it's needed).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srowen/spark SPARK-2749

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1660
    
----
commit 9636794a85e433f3398c5b0dfca589c3b25b82f2
Author: Sean Owen <[email protected]>
Date:   2014-07-30T12:16:18Z

    Add junit dep so that Spark SQL Java tests compile

commit 858ff7c7e076418e504660cdaabd17d62f2e1042
Author: Sean Owen <[email protected]>
Date:   2014-07-30T12:16:46Z

    Add explicit junit dep to other modules with Java tests for robustness

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to