GitHub user keypointt opened a pull request:
https://github.com/apache/spark/pull/12195
[Spark-14300][Docs][MLLIB]Scala MLlib examples code merge and clean up
## What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-14300
Duplicated code found in scala/examples/mllib, below all deleted in this PR:
- DecisionTreeRunner.scala
- DenseGaussianMixture.scala
- DenseKMeans.scala
- GradientBoostedTreesRunner.scala
- LDAExample.scala
- LinearRegression.scala
- SparseNaiveBayes.scala
- StreamingLinearRegression.scala
- StreamingLogisticRegression.scala
- TallSkinnyPCA.scala
- TallSkinnySVD.scala
Unsure code duplications (need doube check), below two deleted:
- Correlations.scala
- FPGrowthExample.scala
## delete reasons:
#### delete: mllib/DecisionTreeRunner.scala
- duplicate of scala/examples/ml/DecisionTreeExample.scala
- DecisionTreeRunner is referenced in
"milib/GradientBoostedTreesRunner.scalaâ, so delete
GradientBoostedTreesRunner.scala
#### delete: mllib/GradientBoostedTreesRunner.scala
- it referencing above DecisionTreeRunner class
- not being referenced
#### delete: mllib/DenseGaussianMixture.scala
- duplicate of mllib/GaussianMixtureExample
#### delete: mllib/DenseKMeans.scala
- duplicate of mllib/KMeansExample
#### delete: mllib/LDAExample.scala
- duplicate of ml/KMeansExample
#### delete: mllib/LinearRegression.scala
- duplicate of mllib/LinearRegressionWithSGDExample
#### delete: mllib/SparseNaiveBayes.scala
- duplicate of mllib/NaiveBayesExample
#### delete: mllib/StreamingLinearRegression.scala
- duplicate of mllib/StreamingLinearRegressionExample
#### delete: mllib/StreamingLogisticRegression.scala
- never being used or referenced
#### delete: mllib/TallSkinnyPCA.scala
- never being used or referenced
#### delete: mllib/TallSkinnySVD.scala
- never being used or referenced
When merging and cleaning those code, be sure not disturb the previous
example on and off blocks.
## How was this patch tested?
est with `SKIP_API=1 jekyll` serve manually to make sure that works well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keypointt/spark SPARK-14300
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12195
----
commit 670ac3edcc1e088e95f6d12e3abeff2a8b403fe7
Author: Xin Ren <[email protected]>
Date: 2016-04-05T22:34:05Z
[SPARK-14300] step 1, delete verified mllib example duplications
commit b4698164cabdb76e019aed5e5f55976c547e606c
Author: Xin Ren <[email protected]>
Date: 2016-04-05T23:14:28Z
[SPARK-14300] step 2, double check not-sure examples
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
