Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12174#issuecomment-206107803
@srowen thanks for the fix.
However, instead of allowing users to call these obsolete constructors and
improving the error messages, I'm inclined to guide users **not to call these
`this(path: String)` constructors** but to call the better
`SparkContext.getOrCreate(path, ...)`, which is also the recommended manner by
our [streaming programming
guide](http://spark.apache.org/docs/latest/streaming-programming-guide.html#checkpointing).
`SparkContext.getOrCreate(path, ...)` was added as the major API for users
to create a StreamingContext from some checkpoint path. Since it is an improved
version of `this(path: String)` constructors, I couldn't think of why users
still want to call `this(path: String)`. So I'm proposing let's deprecated the
`this(path: String)` constructors in https://github.com/apache/spark/pull/12035.
@zsxwing could you take a look at this? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
