Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r58715478
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -391,13 +391,14 @@ abstract class UnixTime extends BinaryExpression with
ExpectsInputTypes {
case StringType if right.foldable =>
val sdf = classOf[SimpleDateFormat].getName
val fString = if (constFormat == null) null else
constFormat.toString
- val formatter = ctx.freshName("formatter")
if (fString == null) {
s"""
boolean ${ev.isNull} = true;
${ctx.javaType(dataType)} ${ev.value} =
${ctx.defaultValue(dataType)};
"""
} else {
+ val formatter = ctx.freshName("sdf")
--- End diff --
Pardon my ignorance but is "sdf" the right name here? I admit I am not
familiar with how the code gen works, but just looking at how it seems to
operate, formatter seems to be a different reference than sdf.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
