Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12209#discussion_r58743959
--- Diff: pom.xml ---
@@ -128,7 +128,7 @@
<slf4j.version>1.7.10</slf4j.version>
<log4j.version>1.2.17</log4j.version>
<hadoop.version>2.2.0</hadoop.version>
- <protobuf.version>2.5.0</protobuf.version>
+ <protobuf.version>2.6.1</protobuf.version>
--- End diff --
This isn't necessarily OK since it changes protobuf for the whole project,
and could conflict with versions used by, say, Hadoop. 2.4 and 2.5 were
terribly incompatible, and I am paranoid about 2.5 vs 2.6.
The KCL update itself is probably fine. Is that helpful at all by itself?
you'll have to update the deps files to reflect the updated dependencies for
tests to pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
