Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/12200#discussion_r58752409
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala ---
@@ -183,6 +183,19 @@ class CountVectorizerSuite extends SparkFunSuite with
MLlibTestSparkContext
case Row(features: Vector, expected: Vector) =>
assert(features ~== expected absTol 1e-14)
}
+
+ // CountVectorizer test
--- End diff --
Might want to write a better comment here and on ln178 to indicate that
`cv` is testing binary toggle creating model from vocab and `cv2` is testing
from fitting the model to a df
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
